-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade all dependencies #3808
Draft
mattmb
wants to merge
21
commits into
master
Choose a base branch
from
u/mmb/brave-or-crazy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade all dependencies #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmb
force-pushed
the
u/mmb/brave-or-crazy
branch
4 times, most recently
from
February 22, 2024 18:19
bf4f7a7
to
62dd4ef
Compare
I'm not really sure this is a good idea but I'm curious to see how badly the tests fail. If it's not too hard to fix them I might chip away at this branch so we can close some of the open PRs from dependabot
New pip needed since a dependency doesn't have setup.py. venv-update ties us to an old pip. Try not using venv-update which is maybe a shame but the only way forward. Maybe we should move to poetry but not sure how easy that would be?
Can't just upgrade this, lots of stuff has changed and prob would need to bump in sticht. Also websockets is linked and tied to requirements in kubernetes module too. So avoid this for now...
No idea if this is okay tbh but let's see if it at least works. I stripped out the paasta venv because it seems unneccesary but I could be wrong...
New version needs more modern python I think...
Also needs a newer python I think
This reverts commit 7927a1e.
This reverts commit 170a00a.
I think in retrospect I still want this and can pin the tox versions outside of tox itself
mattmb
force-pushed
the
u/mmb/brave-or-crazy
branch
from
March 13, 2024 17:28
4812647
to
51dbe99
Compare
Old version uses 2to3 via setuptools which is now deprecated, bump to latest dev version including a Yelp patch
Not sure how this worked before but I don't think we care anyway
mattmb
force-pushed
the
u/mmb/brave-or-crazy
branch
from
March 13, 2024 18:51
c91b090
to
f766499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure this is a good idea but I'm curious to see how badly the tests fail. If it's not too hard to fix them I might chip away at this branch so we can close some of the open PRs from dependabot