Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable generating badge #405

Closed
wants to merge 8 commits into from
Closed

Reenable generating badge #405

wants to merge 8 commits into from

Conversation

vim345
Copy link
Contributor

@vim345 vim345 commented Nov 12, 2021 •
edited
Loading

With this it automatically commits the badge to the repo using add-new-commit after PR is merged.

I have verified it's working on my fork: https://github.com/vim345/nrtsearch

It looks like github-actions[bot] cannot push commits to Yelp repos. I'm trying to see what bot I can use to do that.

@vim345 vim345 mentioned this pull request Nov 12, 2021
Open
@jedrazb jedrazb linked an issue Nov 12, 2021 that may be closed by this pull request
Coverage badge broken in repo readme #400
Open
@jedrazb
Copy link
Contributor

jedrazb commented Nov 12, 2021

The build is failing, it seems to be an unrelated issue:

com.yelp.nrtsearch.clientlib.NodeNameResolverAndLoadBalancingTests > testNodeRemovedFromAddressFile FAILED
    org.junit.runners.model.TestTimedOutException: test timed out after 1000 milliseconds
        at [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
        at [email protected]/java.util.concurrent.locks.LockSupport.park(LockSupport.java:211)
        at app//io.grpc.stub.ClientCalls$ThreadlessExecutor.waitAndDrain(ClientCalls.java:731)
        at app//io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:149)
        at app//com.yelp.nrtsearch.server.grpc.LuceneServerGrpc$LuceneServerBlockingStub.search(LuceneServerGrpc.java:2226)
        at app//com.yelp.nrtsearch.clientlib.NodeNameResolverAndLoadBalancingTests.performSearch(NodeNameResolverAndLoadBalancingTests.java:389)
        at app//com.yelp.nrtsearch.clientlib.NodeNameResolverAndLoadBalancingTests.performSearchAndGetResultCounts(NodeNameResolverAndLoadBalancingTests.java:380)
        at app//com.yelp.nrtsearch.clientlib.NodeNameResolverAndLoadBalancingTests.testNodeRemovedFromAddressFile(NodeNameResolverAndLoadBalancingTests.java:278)

@vim345
Copy link
Contributor Author

vim345 commented Nov 12, 2021

Yes, that was a new error. But prior to that I got this: https://github.com/Yelp/nrtsearch/runs/4184967117?check_suite_focus=true

@sarthakn7
Copy link
Contributor

@vim345 you probably need to add the github secret to the action like its done in https://github.com/Yelp/nrtsearch/blob/master/.github/workflows/tagged_release.yml#L17

@vim345
Copy link
Contributor Author

vim345 commented Nov 15, 2021

@vim345 you probably need to add the github secret to the action like its done in https://github.com/Yelp/nrtsearch/blob/master/.github/workflows/tagged_release.yml#L17

@sarthakn7 Yes, I think this would solve the issue. I added it in this commit before: 5c6acde

However, another issue was raised that started failing builds. I tried to revert that commit but the error is still there. I'm still trying to figure out what caused the errors in the build.

@vim345
Copy link
Contributor Author

vim345 commented Sep 1, 2022

This was fixed here: #476

@vim345 vim345 closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jedrazb jedrazb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage badge broken in repo readme
3 participants
@vim345 @jedrazb @sarthakn7