Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve guideline #3

Open
avedetvedea opened this issue Oct 2, 2022 · 0 comments
Open

Improve guideline #3

avedetvedea opened this issue Oct 2, 2022 · 0 comments

Comments

@avedetvedea
Copy link

avedetvedea commented Oct 2, 2022

At the beginning of the guideline, an example was given under Type of types, as EventsPageLeftRailAttendWidget under Domain specific types. This didn't really click to me, where seconds later under the part Describe the data, not the view, an example was given as:

Put in Yelpy terms; don't add a "UserProfileCard" type to return down the data to render a user's information in a Profile component.

Instead, use the existing User type and return that to populate the Profile card component.

This occurs to me as an inconsistency in the guideline. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant