-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace IntervalScheduler with GrocIntervalScheduler #78
Comments
Just to clarify, this would let us do "every 3 hours between 10AM and 3PM". |
+1. This would make it possible to run our hourly batches during the daytime hours. |
I was blocked on some things today, so I started a branch for this, forking from |
For reference: GAE cron syntax |
I was bored after work and wrote a parser for this. No actual scheduler yet. |
This can be bumped to the next release. |
I don't know if I'm going to ultimately have time to hook up the parser with the actual I can still try to find time to do it in between my other work, I just can't give you a specific delivery date. |
I took a look at this again. I noticed that the appengine.cron package has a parser already, and the package is only dependent on core python packages. What do you think about creating a package out of everything under: That would allow us to create a scheduler which uses this parser/scheduler but would only attempt to import the package when a job is configured to use this scheduler. It would also mean we'd support the full groc syntax. |
The parser uses antlr3, which I thought wasn't in the standard library. |
Ah, true. I guess I meant that there weren't any other google appengine dependencies. If someone wanted to use the groc scheduler, they'd have to install antlr3 and this new package that we would make. |
I'd rather see fewer dependencies.. Besides, the existing daily parser implements most available daily scheduler features, and the other parser just needs a little glue to work. I admit regexes are not the cleanest solution, but they match correct expressions correctly. Maybe in the future there could be some sort of scheduler plugin system. |
There is now a general purpose time specification ( https://github.com/irskep/Tron/blob/new_interval_scheduler/tron/config/schedule_parse.py |
In order to have jobs run at the top of every hour, and synchronize intervals even in the face of DST, we should hook up groc's
IntervalTimeSpecification
to our interval scheduler.The text was updated successfully, but these errors were encountered: