Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Saving Root to OnSaving #3236

Open
Dusty-Sprinkles opened this issue Dec 1, 2024 · 1 comment
Open

Add Saving Root to OnSaving #3236

Dusty-Sprinkles opened this issue Dec 1, 2024 · 1 comment
Labels
New Feature A new addition, whose complexity hasn't been evaluated yet triaged This issue has been assessed

Comments

@Dusty-Sprinkles
Copy link

Is your feature request related to a problem? Please describe.

A number of times people have wanted ways to tell when they are saving an object for various reasons, and on a recent issue it was suggested to make a feature request for this, I personally think it would be somewhat useful for some systems that want to clean up assets/reset to a normal state on saving, but not trigger in case of a more general save.

Describe the solution you'd like

Some output of the target hierarchy being saved via the OnSaving node or a different new node with that information (if its heavy to include/would be undesirable to just replace it)

Describe alternatives you've considered

dealing with uncertainty

Additional Context

We could potentially add more information to the saving event which would let you determine the scope of what's being saved. You'd have to make a new issue for this.

Originally posted by @Frooxius in #3228

Requesters

novafox21, krzeszny,
dusty sprinkles/venport

@Dusty-Sprinkles Dusty-Sprinkles added the New Feature A new addition, whose complexity hasn't been evaluated yet label Dec 1, 2024
@shiftyscales shiftyscales removed their assignment Dec 1, 2024
@ProbablePrime ProbablePrime changed the title Add Saving Root to OnSaved Add Saving Root to OnSaving Dec 1, 2024
@ProbablePrime
Copy link
Member

ProbablePrime commented Dec 1, 2024

I took a look at this randomly, There is an IWorldElement "SaveRoot" in scope where this event chain is started.

This seems very doable.

Oh and I just changed the title to avoid confusion.

@shiftyscales shiftyscales added the triaged This issue has been assessed label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new addition, whose complexity hasn't been evaluated yet triaged This issue has been assessed
Projects
None yet
Development

No branches or pull requests

3 participants