Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard character repeat delay #3226

Open
SizemoreSystem opened this issue Nov 27, 2024 · 10 comments
Open

Keyboard character repeat delay #3226

SizemoreSystem opened this issue Nov 27, 2024 · 10 comments
Labels
bug Something isn't working as intended. triaged This issue has been assessed

Comments

@SizemoreSystem
Copy link

Is your feature request related to a problem? Please describe.

There appears to be no option in the settings equivalent to these Windows settings:
Image
There also appears to be no accessibility options in the settings at all.

Describe the solution you'd like

Adding an option to control how long you have to hold a key for before it starts repeating.

Describe alternatives you've considered

It may also be helpful to pull from Windows settings for this, or the operating system's equivalent, however, this may still be an issue, as it is harder to type on Resonite's keyboard versus a hardware keyboard.

Additional Context

No response

Requesters

Sizemore System (@www.sizemo.re) on Discord.

@SizemoreSystem SizemoreSystem added the New Feature A new addition, whose complexity hasn't been evaluated yet label Nov 27, 2024
@Frooxius
Copy link
Member

The system is actually supposed to use your Windows setting for that.

Is that not working for you?

I don't know if we should add our own settings for this. I think keeping it consistent with your system settings is better.

@shiftyscales shiftyscales added the needs more information More information is requested about this issue. label Nov 27, 2024
@shiftyscales shiftyscales removed their assignment Nov 27, 2024
@SizemoreSystem
Copy link
Author

The system is actually supposed to use your Windows setting for that.

Is that not working for you?

I don't know if we should add our own settings for this. I think keeping it consistent with your system settings is better.

It uses it in desktop mode, however, the setting doesn't seem to take affect in VR.
https://github.com/user-attachments/assets/abc62659-2119-4958-973f-39970209b7cc

@AwesomeTornado
Copy link

AwesomeTornado commented Nov 27, 2024

This may actually be caused by #24, when two lasers are resting on a button at the same time.

Edit: Nvm, the video shows otherwise

@shiftyscales
Copy link
Collaborator

If it doesn't work in VR specifically but does in desktop, it sounds like it could possibly be a bug, then? Curious for further input from @Frooxius.

@shiftyscales shiftyscales added triaged This issue has been assessed bug Something isn't working as intended. and removed needs more information More information is requested about this issue. New Feature A new addition, whose complexity hasn't been evaluated yet labels Nov 27, 2024
@art0007i
Copy link

I don't think this is a bug. In desktop it works because the keyboard driver on windows handles key repeat. while in vr the virtual keyboard component handles key repeat.

Also on desktop mode arrow keys, the delete key and pasting using ctrl+v do not respect the system's key repeat settings, and instead repeat at the FrooxEngine defined rate. (Found in FrooxEngine.TextEditor.EditCoroutine, tested by lowering the key repeat in windows and noticing that it's much faster in game)

@SizemoreSystem
Copy link
Author

I don't think this is a bug. In desktop it works because the keyboard driver on windows handles key repeat. while in vr the virtual keyboard component handles key repeat.

Also on desktop mode arrow keys, the delete key and pasting using ctrl+v do not respect the system's key repeat settings, and instead repeat at the FrooxEngine defined rate. (Found in FrooxEngine.TextEditor.EditCoroutine, tested by lowering the key repeat in windows and noticing that it's much faster in game)

Is there a way to edit the FrooxEngine defined rate?

@art0007i
Copy link

art0007i commented Nov 28, 2024

not currently. Right now the default values are 0.25 seconds for the delay, and 30hz for the repeat rate and they cannot be changed in any way

@SizemoreSystem
Copy link
Author

not currently. Right now the default values are 0.25 seconds for the delay, and 30hz for the repeat rate and they cannot be changed in any way

I see. Then there truly is no current alternative, I guess.

@art0007i
Copy link

art0007i commented Dec 3, 2024

Created a mod that can change these.
https://github.com/art0007i/KeyRepeatAdjust

@SizemoreSystem
Copy link
Author

Created a mod that can change these.
https://github.com/art0007i/KeyRepeatAdjust

Thank you! This is incredibly helpful. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended. triaged This issue has been assessed
Projects
None yet
Development

No branches or pull requests

5 participants