Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ben.Demystifier is included in build but appears to not be used #3224

Open
XDelta opened this issue Nov 27, 2024 · 2 comments
Open

Ben.Demystifier is included in build but appears to not be used #3224

XDelta opened this issue Nov 27, 2024 · 2 comments
Labels
New Feature A new addition, whose complexity hasn't been evaluated yet triaged This issue has been assessed

Comments

@XDelta
Copy link
Contributor

XDelta commented Nov 27, 2024

Is your feature request related to a problem? Please describe.

It appears that https://github.com/benaadams/Ben.Demystifier has been included in builds for a long time but isn't being used in the code anywhere from what I can tell. It could be helpful to start using it as it can improve the readability of many stack traces.

The main repo hasn't been updated in a while but Sentry looks like they've been maintaining their own fork here https://github.com/getsentry/Ben.Demystifier (Although without any provided builds on the repo), there hasn't needed to be much updated though and it appears to be working upto atleast .NET 8 and they've recently been updating to net 9 in their own project.

This is included with the game already (Last checked Beta 2024.11.19.479), just not hooked up.

Describe the solution you'd like

For this library to be used as it should make stack traces in the logs more readable. This should assist in locating and finding what caused errors in code.

Describe alternatives you've considered

Patch in usage via a mod or plugin

Additional Context

This would assist mod/plugin developers as well.

Requesters

_deltawolf

@XDelta XDelta added the New Feature A new addition, whose complexity hasn't been evaluated yet label Nov 27, 2024
@shiftyscales
Copy link
Collaborator

Hmm- I found a fairly old commit from @Frooxius that notes:

  • Remove Ben.Demystifier dependency due to almost non-existent usage

It sounds like there still may be some remnants of that kicking around then? Seeking input from @Frooxius.

@shiftyscales shiftyscales added the triaged This issue has been assessed label Nov 29, 2024
@Frooxius
Copy link
Member

There were some issues with this library mangling some stuff that actually made debugging harder, so we removed the usage a lot.

It might be in a few places still, but it's not really something that'd be high priority right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new addition, whose complexity hasn't been evaluated yet triaged This issue has been assessed
Projects
None yet
Development

No branches or pull requests

3 participants