-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments missing #2
Comments
@fukusuket Whenever you have time, could you take a look at this? I'd like to use the converted rules for triage but will be harder if comments are missing. |
@YamatoSecurity |
@fukusuket There is an example at the top, for example rule In the original rule, on line 18 it says |
@YamatoSecurity
Unfortunately, in the above case, it is difficult to retain comments because the original values have been rewritten... :( |
On the left are our converted rule and the right has the original sigma rule. There seems to be a missing comment:
Note: In the case of...
@fukusuket Whenever you have time, could you see if you can keep these comments as well?
Also,
- 'ping'
gets converted to- ping
which is still valid YAML so is no problem, but would like to still keep the single quotes intact if it is not difficult to do.The text was updated successfully, but these errors were encountered: