Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments missing #2

Open
YamatoSecurity opened this issue May 3, 2024 · 4 comments
Open

Comments missing #2

YamatoSecurity opened this issue May 3, 2024 · 4 comments
Assignees
Labels
invalid This doesn't seem right under-investigation

Comments

@YamatoSecurity
Copy link
Contributor

Screenshot 2024-05-03 at 08 12 10

On the left are our converted rule and the right has the original sigma rule. There seems to be a missing comment: Note: In the case of...
@fukusuket Whenever you have time, could you see if you can keep these comments as well?

Also, - 'ping' gets converted to - ping which is still valid YAML so is no problem, but would like to still keep the single quotes intact if it is not difficult to do.

@YamatoSecurity YamatoSecurity added the invalid This doesn't seem right label May 3, 2024
@YamatoSecurity YamatoSecurity transferred this issue from Yamato-Security/hayabusa-rules Jun 4, 2024
@YamatoSecurity
Copy link
Contributor Author

@fukusuket Whenever you have time, could you take a look at this? I'd like to use the converted rules for triage but will be harder if comments are missing.

@fukusuket
Copy link
Collaborator

@YamatoSecurity
Could you give me a specific case where the comment does not remain? (Basically, the comment is supposed to remain, and it is probably a case where the comment cannot remain due to the addition of node, etc.)

@YamatoSecurity
Copy link
Contributor Author

@fukusuket There is an example at the top, for example rule ded2b07a-d12f-4284-9b76-653e37b6c8b0.

In the original rule, on line 18 it says # Note: In the case of sysmon and similar logging utilities, see this discussion https://github.com/SigmaHQ/sigma/discussions/4277 but this comment is not there in the converted rules.

@fukusuket
Copy link
Collaborator

fukusuket commented Sep 5, 2024

@YamatoSecurity
Comments disappear in the following cases

  • The line immediately following detection
  • If you are converting field names (e.g., process_creation(builtin 4688))

Unfortunately, in the above case, it is difficult to retain comments because the original values have been rewritten... :(
Pending until another solution is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right under-investigation
Projects
None yet
Development

No branches or pull requests

2 participants