Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intl #23

Closed
pcg92 opened this issue Apr 29, 2019 · 10 comments
Closed

Add intl #23

pcg92 opened this issue Apr 29, 2019 · 10 comments

Comments

@pcg92
Copy link

pcg92 commented Apr 29, 2019

I think that any good starter requires i18n

@jackple
Copy link
Collaborator

jackple commented Apr 29, 2019

it's a good recommendation, I will think about it!

@pcg92
Copy link
Author

pcg92 commented May 4, 2019

Im trying to integrate this in the boilerplate
https://github.com/akameco/babel-plugin-react-intl-auto/tree/master/examples/with-typescript

But Im getting problems running the script:
UnhandledPromiseRejectionWarning: SyntaxError ... PageLoading/index.scss.d.ts: Unexpected reserved word 'interface'

Edit:
I have tried this:
BANG88/typescript-react-intl#19
And its working nice

@jackple
Copy link
Collaborator

jackple commented May 5, 2019

@pcegarra
feat/intl
I have created a new branch for this, can you make a pr?

@pcg92
Copy link
Author

pcg92 commented May 5, 2019

Done, check the pr
27fef64

To try it just change the state to 'es' in the LanguageProvider component, we probably need to create a store to handle this

@jackple
Copy link
Collaborator

jackple commented May 6, 2019

@pcegarra #25 (comment)

I'm getting some test result before merge

@jackple jackple pinned this issue May 6, 2019
@pcg92
Copy link
Author

pcg92 commented May 6, 2019

Nice, what about https://ant.design/components/locale-provider/?

@jackple
Copy link
Collaborator

jackple commented May 6, 2019

@pcegarra yeah, I'm using LocaleProvider in my company project.

@pcg92
Copy link
Author

pcg92 commented May 6, 2019

Do you plan to add it in feat/react-intl-universal?

@jackple
Copy link
Collaborator

jackple commented May 6, 2019

@pcegarra yes

@jackple
Copy link
Collaborator

jackple commented May 7, 2019

@pcegarra bdecb14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants