bug: blocking IO in async contexts

[twuebi]

Currently, there exist a number of functions used in async contexts that perform blocking IO. This can cause hard to debug issues (https://ryhl.io/blog/async-what-is-blocking/). An initial proposal which replaced std::fs calls on non-wasm targets by tokio::fs calls was done in #458 but rejected as it would have meant not being generic over async runtimes.

[Xuanwo]

Should be fixed by our new Context design:

reqsign/crates/reqsign/src/context.rs

Lines 8 to 13 in d38265a

	#[derive(Debug, Clone)]
	pub struct Context {
	fs: Arc<dyn FileRead>,
	http: Arc<dyn HttpSend>,
	env: Arc<dyn Env>,
	}

[twuebi]

Nice!

Browsing a bit, I found some std::fs calls in other places, e.g.

reqsign/services/google/src/credential.rs

Line 214 in 52e2b7e

let content = std::fs::read(path).map_err(|err| {

[Xuanwo]

Nice!

Browsing a bit, I found some std::fs calls in other places, e.g.

reqsign/services/google/src/credential.rs

Line 214 in 52e2b7e

let content = std::fs::read(path).map_err(|err| {

Yep, still working on migrating all usages.