Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding XDI files containing data as chi(k), chi(R), or Filtered[chi(k)] #33

Open
bruceravel opened this issue Aug 26, 2014 · 1 comment

Comments

@bruceravel
Copy link
Member

This is one of a short string of issues I am opening up after doing some work on the specification document leading up to #28.

The table of array labels in the dictionary has entries for χ(k) and χ(R). It seems the k and r columns should have units. For k, this is presumably inverse Angstroms. For r, Angstroms, picometers, or nanometers (with Angstroms preferred).

Some questions:

  1. Should Angstrom be spelled with or without diacritic marks over the "A" and "o"?
  2. And should "inverse Angstrom" be two words with a space between, or a single word (either concatenated or with an underscore)?

Regarding 1, I suggest recognizing [ÅåAa]ngstr[öo]ms?

Regarding 2, The explanation of values with units in the dictionary, as written, is ambiguous as to whether the string explaining the units is a single word or may be multiple words. I propose "inverse
Angstrom" with the multiple spelling of Angstrom suggested above.

@newville
Copy link
Member

Are you suggesting that XDI support unicode? Or is that "only" ISO-8859-1?
A PR that handles unicode (or even ISO-8859-1) in the C and Fortran readers would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants