Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C xdi_reader passing tests on baddata that should give useful message #24

Open
newville opened this issue Sep 6, 2012 · 1 comment
Open

Comments

@newville
Copy link
Member

newville commented Sep 6, 2012

Including:

inconsistent number of columns
NaN in data
strings in data

and so on.

Currently missing '# Column.N ' lines are silently ignored, replaced by a label of 'colN', and too many column labels is also silently ignored. No opinion on correct behavior -- could simply document this tolerant behavior.

@bruceravel
Copy link
Member

I noticed this this week, then came across this issue. Given that xdifile is returning positive error codes as warnings, along with error messages, it seems appropriate to return a warning/comment for each of those situations.

I didn't include this in today's PR, but will implement it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants