Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and access #54

Open
alain01 opened this issue Nov 15, 2021 · 16 comments
Open

Search and access #54

alain01 opened this issue Nov 15, 2021 · 16 comments

Comments

@alain01
Copy link
Contributor

alain01 commented Nov 15, 2021

Hi,
I think there is a pb between the search result and the permission to access information.

Exemple ?
Search on "tad_cbox"
https://www.monxoops.fr/search.php?query=tad_cbox&action=results

There is 1 result but the access is not authorized.

The search result should not find anything, normally.

@ggoffy
Copy link
Collaborator

ggoffy commented Nov 16, 2021

hi Alain

yes, I know this, but there are two possibilities:

  1. A guest user is visiting your website, and with search he should only see want he is allowed as guest
  2. A guest user is visiting your website, and with search he should also see items, which are visible in detail only for registered users, because you want to "force" him to register and to log in

current code works for example 2
for example 1 I would have to change the code

@alain01
Copy link
Contributor Author

alain01 commented Nov 16, 2021

Hi Goffy
Ok I understand but so,
we need to show a text like:

Reserved access!
This page is restricted.
You must be at least a logged-in member to access the content of this page.

as at present
it seems that there is a bug

@ggoffy
Copy link
Collaborator

ggoffy commented Nov 17, 2021

hi

then goto language/english/global.php and change define for _NOPERM in this way ;)

@alain01
Copy link
Contributor Author

alain01 commented Nov 17, 2021

Hi,
I haven't looked at this file yet but there is a problem BEFORE.
As I am logged in, I arrive on the same page.
So it's just not accessible information.

You can give it a try, you have an account.
So there should be 2 types of display:

  • Reserved access!
  • Your administrator has not activated the display of this page because the module is not approved
    (if the display is not done for this reason...)

@ggoffy
Copy link
Collaborator

ggoffy commented Nov 17, 2021

ah, now I understand want you mean: you didn't approve tad_cbox and therefore nobody should see it on user side. I will change the code for search to return back only approved repos.

@alain01
Copy link
Contributor Author

alain01 commented Nov 17, 2021

Exactly ;-))))))))

@ggoffy
Copy link
Collaborator

ggoffy commented Nov 17, 2021

please test last version

@alain01
Copy link
Contributor Author

alain01 commented Nov 18, 2021

Ok,
with this new version the result of this search is empty !
That's fine.
It's ok for that...
... But ;-)))))

Now, I approuved tad_cbox so, the result shows 1 item
then the link go to an empty wggithub page (as admin member too). Why ?

I think I don't really know how to use the wggithub module

@ggoffy
Copy link
Collaborator

ggoffy commented Nov 18, 2021

on my site it works: https://www.myxoops.org/modules/wggithub/index.php?op=show&dir_id=1&repo_id=119

maybe a problem with character sets?

@alain01
Copy link
Contributor Author

alain01 commented Nov 18, 2021

Ha ?
Ok, thank you for your feedback and test.
This repository was just an example.
I didnt see that !
Ok,
I'll try something else.

@alain01
Copy link
Contributor Author

alain01 commented Nov 18, 2021

Humm
I validated a new module, tag Module
Then :
https://www.monxoops.fr/search.php?query=tag&action=results

result : ok, find 1 item for github
but the link show a wggithub module with an empty page.
May some parameter in the module are not well positioned...

@alain01
Copy link
Contributor Author

alain01 commented Nov 18, 2021

Ok, I search xmcontent :
result ok, 1 item for wggithub with this link

Texte : xmcontent (GregMage)
Link : https://www.monxoops.fr/modules/wggithub/index.php?op=show&dir_id=1&repo_id=4

This link doesnt work,
not blank page but empty wggithub page

@ggoffy
Copy link
Collaborator

ggoffy commented Nov 19, 2021

your website shows an error(maybe not related to this problem):
image

BUT: do you have the same problem if you are using xbootstrap theme?

@alain01
Copy link
Contributor Author

alain01 commented Nov 24, 2021

Yes, no problem with the default template.
Ok, so I need to investigate on it...

@alain01
Copy link
Contributor Author

alain01 commented Nov 25, 2021

If you find the problem in the bt4 template file before me, let me know ;-)

@alain01
Copy link
Contributor Author

alain01 commented Nov 28, 2021

Ok,
The problem is present with the search result,
I meet no problem in the module.
I think the problem comes with the tabs.
With theses tabs, the url doesnt work:
https://www.monxoops.fr/modules/wggithub/#menu1
https://www.monxoops.fr/modules/wggithub/#tabdetail4

All theses links go to https://www.monxoops.fr/modules/wggithub/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants