Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/functions.php #23

Open
ggoffy opened this issue May 26, 2020 · 5 comments
Open

include/functions.php #23

ggoffy opened this issue May 26, 2020 · 5 comments

Comments

@ggoffy
Copy link
Collaborator

ggoffy commented May 26, 2020

is there a common standard, which functions should be really in include/functions.php?

@mambax7
Copy link

mambax7 commented Aug 1, 2020

none :)

The preference is to consolidate functions into class files, so we can avoid polluting globals.

See: https://github.com/jupeter/clean-code-php#dont-write-to-global-functions

@ggoffy
Copy link
Collaborator Author

ggoffy commented Aug 2, 2020

hi. this is not what I mean: at the moment there are some functions in include/functions.php, where I do not know, whether we need them or not. In the creation file they are still hard coded, and if they are not needed any more I will remove them, and not "translation" to current methods

@ggoffy
Copy link
Collaborator Author

ggoffy commented Aug 2, 2020

e.g. wgtransifex_block_addCatSelect, wgtransifexGetMyItemIds and so on - do we need them?

@mambax7
Copy link

mambax7 commented Aug 2, 2020

Are you talking about the functions.php in ModuleBuilder, or functions.php that are in the created module?

@ggoffy
Copy link
Collaborator Author

ggoffy commented Aug 2, 2020

the one which are created in the module ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants