-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Make a dynamic resolution finder #108
Comments
https://github.com/EpicUnknown/anime-dl/tree/experimental I've made it functional, however the code is ugly so I am going to pretty it up first. |
Thanks Epic, appreciate the work on this. I have some more show examples in issue #86 For example, Full Metal Panic on Crunchy has 1440x1080 for their first season I believe and I couldn't get the current code base to run on Ubuntu with Python 3 to test anything. |
Anytime! I just enjoy coding really haha. If you use my experimental build and type "-r 1080" it will download your video just fine at 1080 quality. I removed the height check so now it only needs to find 1080 in the 1440x1080 resolution in the m3u8 file. Let me know if it works out for you so I can either fix it or be happy knowing the dynamic resolutions works for someone else as well. |
Awesome, I had to to some configuring on my Ubuntu and add cfscrape, bs4, and tqdm; but its working now and downloading the 1440x1080 episodes no problem. Once those finish, I'll give the other shows a try as well. |
Awesome! Glad it works, I'll clean up the code so no one else has to look at the ugly mess haha |
Looking forward for seeing the dynamic resolutions PR raised an approved ;). |
It's pretty much done. Just not approved haha |
Any progress on this, I'm willing to help test |
@axipher It's been done boss man. You will have to use my fork though. I haven't pushed these changes to Xonshiz main because I've re-written alot of the script. It also now supports Python 3.8. Quick Edit: It's called anime-dl_re-rewrite. I've been working on it for a bit now |
Ah okay, I'll give yours another try tonight as I think I did once before but the copy I have downloaded wasn't working last night for a show, can't remember the error, but I'll report back on your fork if I find anything. |
@axipher I just made my rewrite public lol I think you were using my fork of anime-dl. Try using my actual re-write repo. But yes please let me know if it works, it's worked for me for awhile now but things change. Also, please use the no_login branch. It is the most up-to-date |
This would be simple, I am currently working on it but maybe someone has a better way of doing it so I'll post it here..
I was thinking about making it so you could specify multiple resolutions in the "-r" field, such as "-r 720,480,360" so it will work in the order you give it.
Also adding an "-all" argument so that way when you can't figure out what resolution a video is, you can run this argument and it will spit out all the m3u8 file info that is needed without any hassle.
Again, this is something I'm playing with at the moment but would like to open the challenge to others! :)
The text was updated successfully, but these errors were encountered: