Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same algorithm to be generalized #630

Open
Xiangyu-Hu opened this issue Jul 25, 2024 · 0 comments
Open

Same algorithm to be generalized #630

Xiangyu-Hu opened this issue Jul 25, 2024 · 0 comments

Comments

@Xiangyu-Hu
Copy link
Owner

The formulation on viscous force

force += e_ij.dot((kernel_correction_(index_i) + kernel_correction_(index_j)) * e_ij) *
mu_(index_i, index_j) * vel_derivative *
inner_neighborhood.dW_ij_[n] * Vol_[index_j];

and that on diffusion

const Vecd &grad_ijV_j = this->kernel_gradient_(index_i, index_j, dW_ijV_j, e_ij);
Real surface_area_ij = 2.0 * grad_ijV_j.dot(e_ij) / r_ij_;
Real phi_ij = gradient_species[index_i] - gradient_species[index_j];
d_species += diff_coeff_ij * phi_ij * surface_area_ij;

are the same. Therefore, it would be better to generalize them into a single implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant