Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upload documents from Readable stream #690

Closed
csharpsi opened this issue Jun 26, 2024 · 6 comments
Closed

Unable to upload documents from Readable stream #690

csharpsi opened this issue Jun 26, 2024 · 6 comments

Comments

@csharpsi
Copy link

csharpsi commented Jun 26, 2024

When I perform an export, the file is not attached to the invoice. I have a unit test that proves that the document stream passed into the updateInvoiceAttachmentByFileName function matches the byte array of the test file and that is passing, so I am confident that the issue is with the SDK.

Example effected invoices:

  • 22e3d6d4-3442-444b-b109-fa359bcacef6
  • 3c425103-1d67-4189-9b1f-3ef1baf286e1

The below examples were imported into Xero, the first using the latest version of the xero-node SDK and the second using version 4.17.0

Latest Version

Version 4.17.0

Additionally, I am seeing a console.log message JSON parse body failed which looks to be coming from the SDK here

image

If I can help any further please let me know

Originally posted by @csharpsi in #631 (comment)

Copy link

PETOSS-446

Copy link

Thanks for raising an issue, a ticket has been created to track your request

@elena-dev-thought
Copy link

we experince the same issue, when do you estimate to fix the issue?

@MiscellaneousStuff
Copy link

Same here

@sangeet-joy-tw
Copy link
Contributor

Hey @csharpsi @elena-dev-thought @MiscellaneousStuff

The issue has been addressed in our latest xero-node v9.0.0.

Please try using the latest version and let us know if the issue still persists.

@csharpsi
Copy link
Author

Hi @sangeet-joy-tw
Thanks for the update. Looks like it's working nicely with v9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants