Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorText on successful response #565

Open
tqrecords opened this issue Oct 9, 2024 · 2 comments
Open

ErrorText on successful response #565

tqrecords opened this issue Oct 9, 2024 · 2 comments

Comments

@tqrecords
Copy link

Version: 9.2.0

I have this line in my code for every response received from an api endpoint:

if (result.ErrorText != null) throw new Exception(result.ErrorText);

I'm checking for exceptions too, but I think I added this in as a fallback. In the latest update, it looks like the ErrorText field returns 'OK' on all successful responses. Is this a bug?

Since all my methods contain this fallback, I think I can apply this fix:

if (result.StatusCode != HttpStatusCode.OK) throw new Exception(result.ErrorText);

Wanted to flag because it's weird that the error text fields is populated when there are no errors.

Copy link

github-actions bot commented Oct 9, 2024

PETOSS-643

Copy link

github-actions bot commented Oct 9, 2024

Thanks for raising an issue, a ticket has been created to track your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant