Xero.NetStandard.OAuth2 9.1.0 CreateInvoiceAttachmentByFileNameAsync fails

[DaithiBradley]

SDK you're using (please complete the following information):

• Version [9.1.0]

Describe the bug
When attempting to update a file to an invoice in version 9.1 an exception is returned.

Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: T. Path '', line 0, position 0. at bool Newtonsoft.Json.JsonTextReader.ParseValue() at bool Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, bool hasConverter) at object Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, bool checkAdditionalContent) at object Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType) at object Newtonsoft.Json.JsonConvert.DeserializeObject(string value, Type type, JsonSerializerSettings settings) at T Newtonsoft.Json.JsonConvert.DeserializeObject<T>(string value, JsonSerializerSettings settings)

The response body from developer.xero.com for the API call shows:

The resource you're looking for cannot be found

When the package is downgraded from nuget package 9.1.0 to 8.1.0 the call works as expected with the same code.

Expected behavior
An existing invoice has a file attached to it.

Screenshots
None

Additional context
Nil

[github-actions]

PETOSS-567

[github-actions]

Thanks for raising an issue, a ticket has been created to track your request

[Plasma]

I can also reproduce this issue

[Plasma]

@DaithiBradley I've got a workaround you can use, likely due to having a space or other unescaped value in the URL path due to the Filename parameter.

If you're using a Filename such as Example - With Spaces.pdf this is not URL path encoded (eg to Example%20-%20With%20Spaces.pdf) and so the requested URL becomes invalid when the SDK attempts to POST the file. Specifying a filename without spaces succeeds. Previous SDK encoded this parameter automatically.

Suggested solution is for the SDK to encode this parameter using Uri.EscapeDataString(filenameToUse) and in the interim you can do this yourself before passing the filename parameter to the SDK method.

See https://developer.xero.com/documentation/api/accounting/attachments

[Plasma]

Found this is mentioned in #570 (linking these tickets)