-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor how imports work #2
Comments
Hi @JayFoxRox Can you explain me what libraries do you want to import? Some examples: In the follow link you can find more information: |
This is not so much about imports from other dependencies. It's about importing our own code, basically inter-module dependencies. I don't really know myself what is there to fix to be honest. I just wish some python coder would look over this, and do a massive refactor to set up a good skeleton for further work. Again: I'm not a python coder, so it's really hard to explain what exactly is wrong; however, I have heard (and also see myself) that it is quite horrible. It used to be that xboxpy was more like a bash-script: you included xbox.py (now called xboxpy.py) and it automatically connected to the Xbox, and the That was done for lazyness as I didn't want to explicitly import each module I needed during initial development of helper scripts. However, some ugly things about this:
These lines from xboxpy.py (originally just th gdb loader) probably also needs some review: # Add ourselves to the module path first
if not "" in sys.path:
sys.path += [""] (which is probably fine for the gdb loader, but not for anything else?) |
Example:
I'm not a python coder, but I assume this is quite horrible..
The text was updated successfully, but these errors were encountered: