Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base version (4f5b433) is outdated #28

Open
JayFoxRox opened this issue May 4, 2020 · 3 comments
Open

Base version (4f5b433) is outdated #28

JayFoxRox opened this issue May 4, 2020 · 3 comments

Comments

@JayFoxRox
Copy link
Member

We should rebase to the latest upstream.

The upstream has added some interesting changes since then; click here to see the diff / list of commits. Most interesting:

In the rebase process, we can also fix #17, and remove our hacks / when we pulled in changes manually (like b770ec6 and potentially 31473f1).

@JayFoxRox
Copy link
Member Author

I'm just leaving this comment as reminder and for exposure.

Some of those are critical issues which cause bad behaviour in otherwise correct nxdk apps.
We should try to do this in the near future.

@JayFoxRox
Copy link
Member Author

JayFoxRox commented Apr 11, 2021

It has been almost a year. So I'm leaving this comment for exposure.

Since then, there's also an implementation of fopen_s and friends (which I'll need for a handful of ports).

@GXTX
Copy link

GXTX commented Oct 3, 2021

Looked into this. Lots of work to be done, got stuck bringing up some threading stuff type changed and we lost eventHandle, there's 2 commits we can drop entirely (wchar, gmt), but someone else should look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants