use fixed-width types when necessary #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, I have yet to test it. |
JayFoxRox
reviewed
Jun 22, 2021
| @@ -1664,7 +1664,7 @@ int extract_file( int in_xiso, dir_node *in_file, modes in_mode , char* path) { | |||
| } | |||
| totalsize += size; | |||
| totalpercent = ( totalsize * 100.0 ) / in_file->file_size; | |||
| exiso_log( "%s%s%s (%lu bytes) [%lu%%]%s\r", in_mode == k_extract ? "extracting " : "", path, in_file->filename, in_file->file_size , totalpercent, "" ); | |||
| exiso_log( "%s%s%s (%u bytes) [%u%%]%s\r", in_mode == k_extract ? "extracting " : "", path, in_file->filename, in_file->file_size , totalpercent, "" ); | |||
There was a problem hiding this comment.
Consider inttypes.h (PRIu32 and friends) so this can't causes issues in the future.
|
In case it's helpful, I just verified that this patch fixes the crash I ran into after fixing the root cause of xemu-project/xemu#509. |
|
Thanks for the patch. This does fix packing CoD:BRO, but does not resolve the issues with Halo 2 MMP. I'll merge as it's improved, but I do not recommend using 64b builds of extract-xiso yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fixed-width types from stdint where it makes sense to do so.
Also fixes a couple of compiler warnings due to mismatching printf arguments on x64 builds.
Should fix #29.
I don't have the games listed in that issue, but I have confirmed that resulting ISOs have matching sha1 sums when hardcoding ftimestamps (patch not included) to ensure reproducible images
Please verify the following before merging:
When running H2:MMP with such a faulty ISO, the game will start but it will fail to install update the game executable and report "out of space" errors when trying to install the maps.
In CoD:BRO, the game will report dirty disc errors before getting to the main menu.