Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A_ADC_Response-PDU or A_SystemNetworkParameter_* not parsed correctly #1021

Open
2 tasks done
farmio opened this issue Aug 24, 2022 · 1 comment
Open
2 tasks done

Comments

@farmio
Copy link
Member

farmio commented Aug 24, 2022

Description of problem:
A_ADC_Response-PDU or A_SystemNetworkParameter_* not parsed correctly.

This was received via a tunnelling connection with an unrelated interface once when first installing a new KNX IP Secure Router to the system.
I failed to reproduce the exception after that. It probably resulted from a system broadcast message.

  • using xknx standalone
  • using Home-Assistant knx integration

Version information:

  • xknx release with the issue: 1.0.0
  • last working xknx / Home-Assistant release (if known):

Traceback (if applicable):

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/local/lib/python3.10/asyncio/selector_events.py", line 1027, in _read_ready
    self._protocol.datagram_received(data, addr)
  File "/usr/local/lib/python3.10/site-packages/xknx/io/transport/udp_transport.py", line 49, in datagram_received
    self.data_received_callback(data, addr)
  File "/usr/local/lib/python3.10/site-packages/xknx/io/transport/udp_transport.py", line 82, in data_received_callback
    knxipframe.from_knx(raw)
  File "/usr/local/lib/python3.10/site-packages/xknx/knxip/knxip.py", line 115, in from_knx
    self.init(self.header.service_type_ident).from_knx(
  File "/usr/local/lib/python3.10/site-packages/xknx/knxip/tunnelling_request.py", line 59, in from_knx
    pos += self.cemi.from_knx(raw[pos:])
  File "/usr/local/lib/python3.10/site-packages/xknx/knxip/cemi_frame.py", line 127, in from_knx
    return self.from_knx_data_link_layer(raw)
  File "/usr/local/lib/python3.10/site-packages/xknx/knxip/cemi_frame.py", line 187, in from_knx_data_link_layer
    self.payload.from_knx(apdu)
  File "/usr/local/lib/python3.10/site-packages/xknx/telegram/apci.py", line 472, in from_knx
    channel, self.count, self.value = struct.unpack("!BBH", raw[1:])
struct.error: unpack requires a buffer of 4 bytes
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please make sure to update to the latest version of xknx (or Home Assistant) and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant