Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement perlin _PARAMS directive #5

Open
2 of 3 tasks
tngreene opened this issue Jul 27, 2020 · 1 comment
Open
2 of 3 tasks

Implement perlin _PARAMS directive #5

tngreene opened this issue Jul 27, 2020 · 1 comment
Assignees
@tngreene
Labels
priority_low Not very important, we'll get to it when we get to it unit_test Issue needs new unit test to cover this
Milestone
XPlaneForExporter...

Comments

@tngreene
Copy link
Contributor

tngreene commented Jul 27, 2020 •
edited
Loading

We have the directives in, but, we don't have the unit tests or do any validations

  • Unit test showing we export the correct values only when enabled

  • Unit test showing we give an error if Amplitude is outside of [-1, 1]

  • Is a wavelength of 0 a problem? Does that mean anything? I think its fine.
@tngreene tngreene added unit_test Issue needs new unit test to cover this priority_high Important, but it can wait labels Jul 27, 2020
@tngreene tngreene self-assigned this Jul 27, 2020
@tngreene tngreene mentioned this issue Jul 27, 2020
Open
11 tasks
@tngreene tngreene added this to the XPlaneForExporter alpha.1 milestone Jul 27, 2020
@tngreene
Copy link
Contributor Author

2f69a1f adds this (and other things) in. We don't have the validations for amplitude because those aren't important right now.

@tngreene tngreene added priority_low Not very important, we'll get to it when we get to it and removed priority_high Important, but it can wait labels Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tngreene tngreene

Labels
priority_low Not very important, we'll get to it when we get to it unit_test Issue needs new unit test to cover this
Projects
None yet
Milestone
XPlaneForExporter beta.1
Development

No branches or pull requests
1 participant
@tngreene