Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_import uses test framework set_materials to configure texture resulting in large numbers of redundant texture nodes #711

Open
ian-m-carr opened this issue Oct 8, 2022 · 0 comments

Comments

@ian-m-carr
Copy link

the feat_import branch uses the unit test code to create blender objects.

Currently create_material takes the texture input but does nothing with it, instead the texture is handled in set_material.

set_material creates the texture node and links it into the material on every call, this results in a redundant node in the material for every prior call.

Moving the texture initialization to the create_material method (where it is documented) and only runnning it if the material does not exist removes the redundant re-initialization of the texture node.

Note: this change may effect the unit tests, separating the code for the import and unit tests would mitigate this risk.

Change in my fork:
5ba487c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants