You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the feat_import branch uses the unit test code to create blender objects.
Currently create_material takes the texture input but does nothing with it, instead the texture is handled in set_material.
set_material creates the texture node and links it into the material on every call, this results in a redundant node in the material for every prior call.
Moving the texture initialization to the create_material method (where it is documented) and only runnning it if the material does not exist removes the redundant re-initialization of the texture node.
Note: this change may effect the unit tests, separating the code for the import and unit tests would mitigate this risk.
the feat_import branch uses the unit test code to create blender objects.
Currently create_material takes the texture input but does nothing with it, instead the texture is handled in set_material.
set_material creates the texture node and links it into the material on every call, this results in a redundant node in the material for every prior call.
Moving the texture initialization to the create_material method (where it is documented) and only runnning it if the material does not exist removes the redundant re-initialization of the texture node.
Note: this change may effect the unit tests, separating the code for the import and unit tests would mitigate this risk.
Change in my fork:
5ba487c
The text was updated successfully, but these errors were encountered: