Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change versioning scheme #10

Closed
rickstaa opened this issue Dec 22, 2020 · 2 comments
Closed

Change versioning scheme #10

rickstaa opened this issue Dec 22, 2020 · 2 comments
Milestone

Comments

@rickstaa
Copy link
Contributor

rickstaa commented Dec 22, 2020

First of all thanks a lot for the great action. Please allow me to throw in one suggestion. Maybe it is an idea to change the versioning scheme to include the v prefix? I think this is the convention used by official GitHub actions like the actions/checkout action. This will prevent confusion when users like me try to use the package based on a specific version:

- name: 'Get Previous tag'
  id: previous_tag
  uses: WyriHaximus/github-action-get-previous-tag@v1

Haya14busa provided a very handy action to make sure the major version tag points to the newest release. You can find it here.

related to #9

@WyriHaximus WyriHaximus added this to the 1.1.0 milestone Dec 22, 2020
@WyriHaximus
Copy link
Owner

Sounds like a good idea @rickstaa ! Always struggled with how to set this up, but since this actions is available that would be very useful! Would you like creating the PR that introduces it?

@rickstaa
Copy link
Contributor Author

rickstaa commented Dec 22, 2020

@WyriHaximus Great! I just created #11. Let me know if you run into troubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants