-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update moon imagery in sky view so phases change #266
Labels
help wanted
Extra attention is needed
Comments
My guess is that the Windows client has a custom shader that implements this effect, and we'd need to port it over. But I think that the surrounding scaffolding to calculate the relevant physical parameters should basically be present in the web engine codebase already, since we have a bunch of the astronomy library code that does this kind of stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is important for a Cosmic Data Stories Mini on the upcoming eclipses.
In the WWT desktop client sky view, the moon image set changes as the phases change. This should be implemented in the web engine. (The moon shown in sky view shouldn't look like a full moon when it's a new moon.)
Edited to note that in particular, it looks like there is a dark shading that appears overlaid on the moon, and the amount/shape of the shading changes with the moon's phases.
Desktop client:
Web client:
The text was updated successfully, but these errors were encountered: