-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HiPS layer serialization compatibility #176
Comments
So far, I see only one place where using GUIDs rather than the dataset name for HiPS layers might have some effect, or would at least cause a externally visible change:
There are ID fields in the various table layer message types in Loading HiPS catalogs (which is done by name) wouldn't be affected. In the C#, this ultimately relies on |
There's a "hack" of sorts present inside the engine, where the ID field of a HiPS catalog layer is set to the name of the dataset, rather than a proper GUID. This doesn't cause any trouble in the web engine itself, but can cause issues with compatibility between various flavors of WWT. In particular, the WWT Windows client expects every layer ID to be a real GUID, and will refuse to load a layer where this isn't the case. This is a problem for things like layer (WWTL) and tour exports.
Changing this on the web engine side seems like the right approach to me. I'm going to take a look through and see where, if anywhere, this change would leak outside of the engine. If anyone else is aware of any such places, let me know here.
The text was updated successfully, but these errors were encountered: