-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error plotting table layers with 200,000 rows #309
Comments
pkgw
added a commit
to pkgw/pywwt
that referenced
this issue
Jul 27, 2021
Addresss WorldWideTelescope#309 the straightforward way. Slow operations can hold up the Qt mainloop enough that the backend convinces itself that the app has become nonresponsive. Note that for the ipywidgets and JupyterLab app backends, the liveness testing is done in the JS frontend code, which really ought to not suffer from this possibility. So those deadlines are staying at their current values, for now.
OK, I've filed #310 for this. I can't actually reproduce the problem on my computer, but the diagnosis seems pretty clear here. |
pkgw
added a commit
to pkgw/pywwt
that referenced
this issue
Jul 27, 2021
Addresss WorldWideTelescope#309 the straightforward way. Slow operations can hold up the Qt mainloop enough that the backend convinces itself that the app has become nonresponsive. Note that for the ipywidgets and JupyterLab app backends, the liveness testing is done in the JS frontend code, which really ought to not suffer from this possibility. So those deadlines are staying at their current values, for now.
pkgw
added a commit
that referenced
this issue
Jul 27, 2021
#310 is merged. Close if you feel satisfied? If a similar problem crops up again, we should think about different strategies (e.g., turning this into a warning rather than an error) but I'm optimistic that this system should be pretty robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following example now crashes:
The error is:
As discussed with @pkgw this is because the table serialization/deserialization takes more than the threshold for testing if the viewer is 'live'. Increasing that threshold does indeed make the error go away.
The text was updated successfully, but these errors were encountered: