Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Approve/Needs Work/Decline Review #26

Open
ty1824 opened this issue Nov 9, 2019 · 0 comments
Open

Feature: Approve/Needs Work/Decline Review #26

ty1824 opened this issue Nov 9, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@ty1824
Copy link
Collaborator

ty1824 commented Nov 9, 2019

A user should be able to approve, decline/reopen, or request additional work on a review using the plugin.

This should be exposed as a trio (+/-) of buttons in the top-right-hand corner of the Active Review View (on the same line as the branch status).

When clicking one of the options, a popup should show giving the user a chance to enter an approval message.

Some hosts may not allow certain actions, this should be configurable via a new method on ReviewHostDefinition.

Discussion:
Should decline/reopen be exposed on the top-level UI, or should it be hidden inside a "additional options" dropdown? Bitbucket takes this approach - declining affects the overall state of the PR, not just what states it can transition to.

@ty1824 ty1824 added the enhancement New feature or request label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant