Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use mps code reviewer with bitbucket cloud #11

Open
bkolb opened this issue Apr 23, 2018 · 4 comments
Open

Unable to use mps code reviewer with bitbucket cloud #11

bkolb opened this issue Apr 23, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@bkolb
Copy link
Contributor

bkolb commented Apr 23, 2018

Bitbucket cloud does not support personal access tokens. Instead one has to create either an app password or an oAuth key. The plugin should be able to deal with either of those.

See https://developer.atlassian.com/cloud/bitbucket/authentication-for-apps/

@justinhorton
Copy link
Contributor

We also need to be wary of API differences between Bitbucket Cloud and Bitbucket Server. We should make separate configurations for each since we'll need to hit different endpoints (and API versions) for the same actions, and possibly hide certain functionality if it's not available.

Here's another page on OAuth2 tokens for Bitbucket Cloud: https://developer.atlassian.com/cloud/bitbucket/oauth-2/

@ty1824 ty1824 added the enhancement New feature or request label Apr 23, 2018
@ty1824
Copy link
Collaborator

ty1824 commented Apr 23, 2018

I agree - and I would expect a new configuration for each of the different offerings (Bitbucket Server, Bitbucket Cloud, and vanilla Bitbucket) as they do/can have some substantial differences. Non-Bitbucket offerings would be the same - different configurations.

@justinhorton
Copy link
Contributor

Here's the doc on creating an application password: https://confluence.atlassian.com/bitbucket/app-passwords-828781300.html

This is how to make a request with that password (Basic auth):

curl --user userName:appPassword https://api.bitbucket.org/1.0/user/repositories

I'm unsure if we want to support this flow, or OAuth2.

@ty1824
Copy link
Collaborator

ty1824 commented May 7, 2018

As App Passwords work effectively the same way as Personal Access Tokens, I would prefer this approach over OAuth2, initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants