Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error more properly for maybeRefreshUser #218

Open
renintw opened this issue Jun 9, 2023 · 0 comments
Open

Handle error more properly for maybeRefreshUser #218

renintw opened this issue Jun 9, 2023 · 0 comments
Labels
good first issue Good for newcomers ui Related to user interface

Comments

@renintw
Copy link
Contributor

renintw commented Jun 9, 2023

A Notice would be a good choice, only the positioning of it may need some work.

wporg-two-factor/settings/src/components/revalidate-modal.js

Lines 58 to 60 in 8011dd2

// TODO: handle error more properly here, likely by showing a error notice
// eslint-disable-next-line no-console
console.error( 'Failed to refresh user record:', error );

@renintw renintw added this to the Iteration 2 milestone Jun 9, 2023
@renintw renintw added good first issue Good for newcomers ui Related to user interface labels Jun 9, 2023
@renintw renintw mentioned this issue Jun 9, 2023
Merged
@StevenDufresne StevenDufresne removed this from the Iteration 2 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ui Related to user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StevenDufresne @renintw