Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice and GlobalNotice #208

Open
renintw opened this issue Jun 1, 2023 · 2 comments
Open

Notice and GlobalNotice #208

renintw opened this issue Jun 1, 2023 · 2 comments
Labels
priority: low ui Related to user interface

Comments

@renintw
Copy link
Contributor

renintw commented Jun 1, 2023

Currently, we have two types of notices: Notice and GlobalNotice.

A Notice is a prompt box that appears in various positions within each component. It could be an error notice, or a warning, info, success notice, etc.

GlobalNotice, on the other hand, is a black prompt box that pops up in a fixed position in the top right corner. Its message is set through setGlobalNotice.

We could consider consolidating these two to enhance readability.

@renintw renintw added ui Related to user interface priority: low labels Jun 1, 2023
@iandunn
Copy link
Member

iandunn commented Jun 1, 2023

They seem to serve different purposes to me, but maybe that's just mainly CSS?

GlobalNotice is more like a Snackbar, so maybe we should use that component instead? Offhand I don't remember why we wrote a custom one.

@renintw
Copy link
Contributor Author

renintw commented Jun 1, 2023

Yeah, that's a good point. Originally, I thought there were probably some reasons for naming it as GlobalNotice so I figured it could reduce confusion by merging the two components. But it looks like we could directly replace GlobalNotice with Snackbar, or these GlobalNotice and Notice naming would be likely to cause some misunderstanding for someone new to the code or when we come back to look at the code after a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low ui Related to user interface
Projects
None yet
Development

No branches or pull requests

2 participants