Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on WebAuthn in wp-admin #114

Closed
7 of 13 tasks
StevenDufresne opened this issue Apr 19, 2023 · 3 comments · Fixed by #153
Closed
7 of 13 tasks

Turn on WebAuthn in wp-admin #114

StevenDufresne opened this issue Apr 19, 2023 · 3 comments · Fixed by #153

Comments

@StevenDufresne
Copy link
Contributor

StevenDufresne commented Apr 19, 2023

For the MVP, let's turn on WebAuthn in the upstream plugin and verify that it works. If it does, I think we can launch with support for privileged users and iterate, adding support for all users.

@StevenDufresne StevenDufresne added this to the MVP milestone Apr 19, 2023
@StevenDufresne StevenDufresne changed the title Turn on WebAuthn in upstream plugin Turn on WebAuthn in wp-admin Apr 19, 2023
@iandunn
Copy link
Member

iandunn commented Apr 19, 2023

We'll need to decide which back-end provider to use. These are the options that I see:

  • The upstream PR: Ideally we'd just use upstream directly instead of maintaining something else, so this might help that. It's not clear if it will be merged, though, or if it'd be a good fit for w.org.
  • Volodymyr's plugin. This looks very good and I'm using it on a personal site. I haven't tested it extensively, though.
  • We could also write our own provider, and try to make it something that could eventually be turned into a PR for upstream. This would probably be the largest amount of work, though. We'd also have to build a UI for it, either for wp-admin or integrating with our custom UI.

Regardless of the approach, we'll want to get a security review. I added a checklist to the issue description so we don't forget.

@pkevan @StevenDufresne @dd32

@StevenDufresne
Copy link
Contributor Author

I'm inclined to go with the first option with the necessary updates as it benefits the community and brings the two factor plugin more up to date in regards to feature support making it more likely to be used and therefore more likely to be maintained.

@iandunn
Copy link
Member

iandunn commented May 3, 2023

Integrating #134 and #146 is turning out to be more time consuming that I hoped, so I'm going to look into running WebAuthn Provider for Two Factor without any customizations -- or minimal customizations -- instead.

If that works well, we could look into if it'd make sense to propose merging it upstream instead of being an add-on.

One issue might be eventually needing to migrate keys from the plugin to upstream, but given the time constraints we'll probably just need to deal with that if it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants