Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the channel title in the messages table #372

Open
andreg opened this issue Jul 10, 2023 · 0 comments
Open

Removing the channel title in the messages table #372

andreg opened this issue Jul 10, 2023 · 0 comments
Labels
[Scope] Model Definition of the data used in the WP Notify project
Milestone

Comments

@andreg
Copy link
Contributor

andreg commented Jul 10, 2023

What problem does this address?

By looking at the notifications_messages table, I think that perhaps the channel_title field is no longer needed, since the relationship of a notification Message with the Channel is established through the channel_name field already, and the human-readable title for the Channel can be fetched by accessing the Channels Registry with Channel_Registry::get_registered, instead.

What is your proposed solution?

To remove the channel_title column from the notifications_messages table.

Please confirm that you have searched existing issues in the repo.

Yes

@Sephsekla Sephsekla added the [Scope] Model Definition of the data used in the WP Notify project label Jul 10, 2023
@Sephsekla Sephsekla added this to the 0.3.0 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Scope] Model Definition of the data used in the WP Notify project
Projects
None yet
Development

No branches or pull requests

2 participants