Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP API to emit a notification #303

Open
Tracked by #302
johnhooks opened this issue Apr 25, 2023 · 0 comments
Open
Tracked by #302

Add PHP API to emit a notification #303

johnhooks opened this issue Apr 25, 2023 · 0 comments
Assignees
Labels
php Pull requests that update Php code [Scope] Service The core logic of the WP Notify project.
Milestone

Comments

@johnhooks
Copy link
Collaborator

What problem does this address?

The current PHP API does not have the functionality to create a notification.

What is your proposed solution?

I propose add a method to the channel class that emits a notification from the registered channel:

$channel->emit( 
  array(
    'message' => __( 'Testing, testing 1, 2, 3... testings', 'wp-feature-notifications' )
  )
);

Questions

  • Does attaching it to the registered channel object make the most sense?
@johnhooks johnhooks added [Scope] Service The core logic of the WP Notify project. php Pull requests that update Php code labels Apr 25, 2023
@johnhooks johnhooks self-assigned this Apr 25, 2023
@Sephsekla Sephsekla added this to the 0.3.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code [Scope] Service The core logic of the WP Notify project.
Projects
None yet
Development

No branches or pull requests

2 participants