Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDIT: Looking at the current UI system and creating an alternative #281

Open
paaljoachim opened this issue Apr 18, 2023 · 5 comments
Open
Labels
[Scope] Boundary - Settings Communication with WordPress' Settings API

Comments

@paaljoachim
Copy link

paaljoachim commented Apr 18, 2023

What problem does this address?

Right now there is a Notifications Settings screen in the submenu of Settings.
Like so

Screenshot 2023-04-18 at 22 48 43

Most likely (I believe) the Notification settings will be added to Settings -> General.

NB! I received feedback in the core-upgrade-install Slack channel here:
https://wordpress.slack.com/archives/CULBN711P/p1681852578240519
One mention was all the various update notifications one can turn on or off.

So I changed the below solution.

What is your proposed solution?

I would suggest adding it directly to WordPress - Settings -> General.
Perhaps something similar to this:

Adding notifications to Settings General screen

NB! The above will not work as there are a lot of notifications that are needed and that would crowd the Settings > General screen.

Here is a new mockup which has a similar UI style as Site health and the Privacy screen.
Adding tabs as there are very likely a lot more notifications options that need to be added.

New screen Notifications settings

Mockup made in Figma:
https://www.figma.com/file/YgQ78OeZg9h4vyFoVsilp3/Settings---Notification-screen?node-id=1%3A4&t=xiVR1LAj1WOq9Zvh-1

Please confirm that you have searched existing issues in the repo.

No

@johnhooks johnhooks added the [Scope] Boundary - Settings Communication with WordPress' Settings API label Apr 18, 2023
@paaljoachim
Copy link
Author

Notifications will need to stay in it's own settings screen because there are for instance a lot of update notifications that will need to be added.

I might need to readjust this whole issue in relation to additional notifications that need to be added, and instead focus on that instead of moving notifications to Settings > General screen.

@paaljoachim paaljoachim changed the title Looking at the current UI system and creating an alternative EDIT: Looking at the current UI system and creating an alternative Apr 18, 2023
@johnhooks
Copy link
Collaborator

The current API design isn't reflected in the current settings screen. The concept is to break notifications into channels, some will be core channels and be namespaced like so core/updates, core/plugin-updates, core/comment-new, they will also have nicer human readable names, but these are designed to be similar to the block type names. The list of notification channels could possibly become quite large because the API will be available for plugins to register their own namespaced channels.

@johnhooks
Copy link
Collaborator

johnhooks commented Apr 18, 2023

@paaljoachim I'm curious to align this project with the Gutenberg design system. See Issue #253, and try be the transition to a new style of Admin area and unify with the block editor. What do you think?

@paaljoachim
Copy link
Author

That means one needs to look at how to group specific channels into possibly specific tabs.
There might be need to have a tab for external plugins and a tab for external themes.
This is easier for a developer to see and the UI will then adjust based on how to group channels etc.


I will reply directly in the #253 issue.

@EdithAllison
Copy link
Collaborator

@Sephsekla This looks superseded by the new Figma designs #253. I am suggesting to close this issue, and continue the conversation in 253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Scope] Boundary - Settings Communication with WordPress' Settings API
Projects
None yet
Development

No branches or pull requests

3 participants