Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Bar Notification Icon #280

Open
2 tasks
johnhooks opened this issue Apr 18, 2023 · 7 comments
Open
2 tasks

Admin Bar Notification Icon #280

johnhooks opened this issue Apr 18, 2023 · 7 comments

Comments

@johnhooks
Copy link
Collaborator

paaljoachim on WordPress Slack left the following suggestions after testing out the plugin.

Bell icon top right corner shows a red color dot. To me it gives a signal that there are notifications to check. I would assume that no dot will signal that all notifications are read. Hovering the bell icon the cursor should change to a hand with a finger showing that it can be clicked.

  • Add the functionality to remove the red dot when there are no new notifications (maybe make it a blue dot).
  • Add { cursor: pointer; } to the bell icon.
@paaljoachim
Copy link

The update bubble in WordPress is red like so:
Screenshot 2023-04-18 at 23 04 24

When the plugins are updated the red bubble is gone.
So perhaps the blue color #2271b1 used in general in WordPress could replace the red dot.

@johnhooks
Copy link
Collaborator Author

@paaljoachim I just prefer blue, I find it a less obnoxious color to indicate new notifications. GitHubs notifications are flagged as new with blue.

@paaljoachim
Copy link

I see that Outlook/hotmail and Slack uses a red dot in the tab.
I will keep my eyes open and see what colors various online sites use.

@erikyo
Copy link
Collaborator

erikyo commented Apr 18, 2023

I had actually already thought about this a little bit, and the NotificationHubIcon component accepts a className argument that can also be used to color the dot.

In my mind the dot color is animated (in runtime) and at the time it is illustrated in the demo (2 new notifications) it should actually be red and the default state should be blue (as the rest of the Wordpress UI interface).

@erikyo
Copy link
Collaborator

erikyo commented Apr 20, 2023

tried to change the color of the notice doc, but tell me what are your throughs...
ringmybell

IMHO the #0071a1 blue color that is used is a bit low-contrast compared to the background and is really not very visible.
the #72aee6 lighter blue color is the color that is used for the hover link

The color used are what I found here some times ago but it seems changed a bit and probably we need to update (although I don't think it will improve the contrast much).

$color-red: #d94f4f; // Alert Red
$color-blue: #0071a1; // Blue Dark 900
$color-blue-light: #72aee6; // Blue 20

@johnhooks
Copy link
Collaborator Author

johnhooks commented Apr 20, 2023

@erikyo The more important issues are to remove the dot when there are no new messages and also change the cursor type on hover to pointer. The color blue was just a suggestion, I agree with concerns about contrast.

@EdithAllison
Copy link
Collaborator

This issue is linked to the new design tracked in #357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants