-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Bar Notification Icon #280
Comments
@paaljoachim I just prefer blue, I find it a less obnoxious color to indicate new notifications. GitHubs notifications are flagged as new with blue. |
I see that Outlook/hotmail and Slack uses a red dot in the tab. |
I had actually already thought about this a little bit, and the NotificationHubIcon component accepts a className argument that can also be used to color the dot. In my mind the dot color is animated (in runtime) and at the time it is illustrated in the demo (2 new notifications) it should actually be red and the default state should be blue (as the rest of the Wordpress UI interface). |
tried to change the color of the notice doc, but tell me what are your throughs... IMHO the blue color that is used is a bit low-contrast compared to the background and is really not very visible. The color used are what I found here some times ago but it seems changed a bit and probably we need to update (although I don't think it will improve the contrast much). wp-feature-notifications/src/styles/vars.scss Lines 7 to 9 in 4d46e31
|
@erikyo The more important issues are to remove the dot when there are no new messages and also change the cursor type on hover to |
This issue is linked to the new design tracked in #357 |
paaljoachim on WordPress Slack left the following suggestions after testing out the plugin.
{ cursor: pointer; }
to the bell icon.The text was updated successfully, but these errors were encountered: