From c6d3a794cf4b1adb249b7eab2eee70392219f06f Mon Sep 17 00:00:00 2001 From: Bero Date: Wed, 11 Sep 2024 12:56:19 +0200 Subject: [PATCH] Update actions/upload-artifact version to 4 (#1748) ## Motivation for the change, related issues [Tests are failing](https://github.com/WordPress/wordpress-playground/actions/runs/10808887583/job/29982862871?pr=1745) because [v1 and v2 of the artifact actions](https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/) were deprecated. ## Implementation details Updated the `actions/upload-artifact` version to 4. ## Testing Instructions (or ideally a Blueprint) - CI --- .github/workflows/build-website.yml | 2 +- .github/workflows/ci.yml | 2 +- .../php-wasm/node/src/lib/networking/inbound-tcp-to-ws-proxy.ts | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-website.yml b/.github/workflows/build-website.yml index e3303c5f08..58ef6f8ae0 100644 --- a/.github/workflows/build-website.yml +++ b/.github/workflows/build-website.yml @@ -34,7 +34,7 @@ jobs: - run: npm run build - run: tar -czf wasm-wordpress-net.tar.gz dist/packages/playground/wasm-wordpress-net # Store dist/packages/artifacts/wasm-wordpress-net as a build artifact - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v4 with: name: playground-website path: wasm-wordpress-net.tar.gz diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 11a17ef1c0..9b73a9bd70 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: - run: sudo ./node_modules/.bin/cypress install --force - run: sudo CYPRESS_CI=1 npx nx e2e playground-website --configuration=ci --verbose # Upload the Cypress screenshots as artifacts if the job fails - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v4 if: ${{ failure() }} with: name: cypress-screenshots diff --git a/packages/php-wasm/node/src/lib/networking/inbound-tcp-to-ws-proxy.ts b/packages/php-wasm/node/src/lib/networking/inbound-tcp-to-ws-proxy.ts index d3eae70b44..ed13ea0ff8 100644 --- a/packages/php-wasm/node/src/lib/networking/inbound-tcp-to-ws-proxy.ts +++ b/packages/php-wasm/node/src/lib/networking/inbound-tcp-to-ws-proxy.ts @@ -56,6 +56,7 @@ export function listenTCPToWSProxy(options: InboundTcpToWsProxyOptions) { 'WS->TCP message:', new TextDecoder().decode(e.data as ArrayBuffer) ); + // @ts-ignore-next-line tcpSource.write(Buffer.from(e.data as ArrayBuffer)); }); wsTarget.addEventListener('close', () => {