Skip to content

Commit

Permalink
Update actions/upload-artifact version to 4 (#1748)
Browse files Browse the repository at this point in the history
## Motivation for the change, related issues

[Tests are
failing](https://github.com/WordPress/wordpress-playground/actions/runs/10808887583/job/29982862871?pr=1745)
because [v1 and v2 of the artifact
actions](https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/)
were deprecated.

## Implementation details

Updated the `actions/upload-artifact` version to 4.

## Testing Instructions (or ideally a Blueprint)

- CI
  • Loading branch information
bgrgicak authored Sep 11, 2024
1 parent 41005cd commit c6d3a79
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- run: npm run build
- run: tar -czf wasm-wordpress-net.tar.gz dist/packages/playground/wasm-wordpress-net
# Store dist/packages/artifacts/wasm-wordpress-net as a build artifact
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: playground-website
path: wasm-wordpress-net.tar.gz
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- run: sudo ./node_modules/.bin/cypress install --force
- run: sudo CYPRESS_CI=1 npx nx e2e playground-website --configuration=ci --verbose
# Upload the Cypress screenshots as artifacts if the job fails
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: cypress-screenshots
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export function listenTCPToWSProxy(options: InboundTcpToWsProxyOptions) {
'WS->TCP message:',
new TextDecoder().decode(e.data as ArrayBuffer)
);
// @ts-ignore-next-line
tcpSource.write(Buffer.from(e.data as ArrayBuffer));
});
wsTarget.addEventListener('close', () => {
Expand Down

0 comments on commit c6d3a79

Please sign in to comment.