Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Determine strategy for block patterns #12

Closed
kjellr opened this issue Oct 5, 2021 · 2 comments
Closed

Determine strategy for block patterns #12

kjellr opened this issue Oct 5, 2021 · 2 comments

Comments

@kjellr
Copy link
Collaborator

kjellr commented Oct 5, 2021

In previous themes, block patterns were bundled directly with the theme itself. We should consider doing that here, but also keep an eye on Pattern Directory progress. Can we instead put these patterns in the directory?

In addition to opening these patterns up to users beyond this single theme, having our patterns in the directory would cut down our theme code considerably, ensure translation is handled automatically, and also make them easier to update on the fly.

Related Gutenberg issue: WordPress/gutenberg#35364

@jffng
Copy link
Collaborator

jffng commented Oct 27, 2021

It appears that this will not be in 5.9, so should we close this one since we will have to bundle them with the theme?

In any case, we can upload them to the patterns directory, even if we can't remove them from the theme.

@kjellr
Copy link
Collaborator Author

kjellr commented Oct 27, 2021

Yep, I think it's fine to close for now. 👍

@kjellr kjellr closed this as completed Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants