Look for badly named files #629
Conversation
davidperezgar
requested review from
barrykooij,
ernilambar and
frantorres
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Stills need duplicated filenames |
|
I believe that is done! |
| // Duplicated filenames. | ||
| $this->assertArrayHasKey( 0, $errors['class-filename.php'] ); | ||
| $this->assertArrayHasKey( 0, $errors['class-filename.php'][0] ); | ||
| $this->assertCount( 1, wp_list_filter( $errors['class-filename.php'][0][0], array( 'code' => 'duplicated_files' ) ) ); |
There was a problem hiding this comment.
Having same file name in separate folders should not be error I believe. From what I understand, duplicate files refers to like this:
filename.php and Filename.php. These two files in same location are treated differently based on operating system.
There was a problem hiding this comment.
But I have to force, I cannot create in my system two files like that.
There was a problem hiding this comment.
How could I do it?
There was a problem hiding this comment.
I cannot create in my MacOS also. May be we need to rewrite test from an array of files names rather than actual filename.
There was a problem hiding this comment.
How can achieve that? some guide to make it?
There was a problem hiding this comment.
You should be able to achieve a positive outcome using things like mocking/overriding the ::get_files method to return a fake list of bad files.
There was a problem hiding this comment.
Any ideas @felixarntz ?
Fixes #628