-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group check results by filename in admin #456
Comments
The results page can indeed be quite confusing because there's no indication how results are grouped and why there can be multiple tables per file. Right now all the tests are run in sequence using Ajax and each check reports its own errors & the files where it found them in. As the check progresses, results are printed. Grouping results per file while this is in progress is probably not as straightforward and could lead to odd experience, as the page might be shuffled around multiple times. It might be easier to just show a spinner while the checks are in progress, and then do the grouping at the end before displaying the final results. |
I would suggest to group by Check so we could make an explanation for all of them. Now is confusing for users and we are not giving a guidance for solving the problems. |
We should also consider another part. Large plugins would take more than a minute to complete all checks. Time will be even higher if plugin is active. Showing spinner for such a long time will be bad UX. So we should find a middle ground. |
We're currently already group / separate the check results by filename. I suggest have only 1 table per filename and appending new findings to a filename table if it already exists.
The text was updated successfully, but these errors were encountered: