Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useEditorTitle: fix wrong request without ID #67475

Merged
merged 2 commits into from
Dec 2, 2024
+45 −0
Merged

useEditorTitle: fix wrong request without ID #67475

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8ccd8d
useEditorTitle: fix wrong request without ID
ellatrix Dec 2, 2024
8443cde
Add e2e test
ellatrix Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/edit-site/src/components/editor/use-editor-title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ function useEditorTitle( postType, postId ) {
const { getEditedEntityRecord, hasFinishedResolution } =
select( coreStore );

if ( ! postId ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the home page of the site editor, there's no postId (and other pages). Won't this have an impact there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the site editor root? Yes, there's an ID it seems, it's the template ID. Which other pages would have no ID? useEditorTitle seems to always be called either the post/page ID or the template ID.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when you are on data view pages, the title does not update, but that's the case in trunk too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, it's currently not erroring because getEditedEntityRecord returns false if it's not loaded yet, which getTemplateInfo is destructuring.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right.

return { isLoaded: false };
}

const _record = getEditedEntityRecord(
'postType',
postType,
Expand Down
Loading