Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useEditorTitle: fix wrong request without ID #67475

Merged
merged 2 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/edit-site/src/components/editor/use-editor-title.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ function useEditorTitle( postType, postId ) {
const { getEditedEntityRecord, hasFinishedResolution } =
select( coreStore );

if ( ! postId ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the home page of the site editor, there's no postId (and other pages). Won't this have an impact there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the site editor root? Yes, there's an ID it seems, it's the template ID. Which other pages would have no ID? useEditorTitle seems to always be called either the post/page ID or the template ID.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when you are on data view pages, the title does not update, but that's the case in trunk too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, it's currently not erroring because getEditedEntityRecord returns false if it's not loaded yet, which getTemplateInfo is destructuring.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right.

return { isLoaded: false };
}

const _record = getEditedEntityRecord(
'postType',
postType,
Expand Down
41 changes: 41 additions & 0 deletions test/e2e/specs/site-editor/preload.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/**
* WordPress dependencies
*/
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );

test.describe( 'Preload', () => {
test.beforeAll( async ( { requestUtils } ) => {
await requestUtils.activateTheme( 'emptytheme' );
} );

test.afterAll( async ( { requestUtils } ) => {
await requestUtils.activateTheme( 'twentytwentyone' );
} );

test( 'Should make no requests before the iframe is loaded', async ( {
page,
admin,
} ) => {
// Do not use `visitSiteEditor` because it waits for the iframe to load.
await admin.visitAdminPage( 'site-editor.php' );

const requests = [];
let isLoaded = false;

page.on( 'request', ( request ) => {
if ( request.resourceType() === 'document' ) {
// The iframe also "requests" a blob document. This is the most
// reliable way to wait for the iframe to start loading.
// `waitForSelector` is always a bit delayed, and we don't want
// to detect requests after the iframe mounts.
isLoaded = true;
} else if ( ! isLoaded && request.resourceType() === 'fetch' ) {
requests.push( request.url() );
}
} );

await page.waitForFunction( ( _isLoaded ) => _isLoaded, [ isLoaded ] );

expect( requests ).toEqual( [] );
} );
} );
Loading