useEditorTitle: fix wrong request without ID #67475
Merged
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Regression
youknowriad
reviewed
Dec 2, 2024
| @@ -22,6 +22,10 @@ function useEditorTitle( postType, postId ) { | |||
| const { getEditedEntityRecord, hasFinishedResolution } = | |||
| select( coreStore ); | |||
|
|
|||
| if ( ! postId ) { | |||
There was a problem hiding this comment.
I think for the home page of the site editor, there's no postId (and other pages). Won't this have an impact there?
There was a problem hiding this comment.
You mean the site editor root? Yes, there's an ID it seems, it's the template ID. Which other pages would have no ID? useEditorTitle seems to always be called either the post/page ID or the template ID.
There was a problem hiding this comment.
I think when you are on data view pages, the title does not update, but that's the case in trunk too?
There was a problem hiding this comment.
Btw, it's currently not erroring because getEditedEntityRecord returns false if it's not loaded yet, which getTemplateInfo is destructuring.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f8ccd8d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12120826554
|
youknowriad
approved these changes
Dec 2, 2024
This was referenced Dec 2, 2024
Merged
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]>
ramonjd
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I think this has been introduced in #66955.
postIdmay be undefined (try the root page in the Site Editor), which is causing a request to/templates(without the ID, so a useless request). This is delaying editor load (though we are not currently measuring it for template editing).Why?
How?
Return early.
Testing Instructions
Open the Site Editor root, and check the first few
fetchrequests. Notice the loader before this PR, after this PR it's only 100ms, so it doesn't really show up.I've added a test so we don't make these regressions again.
Testing Instructions for Keyboard
Screenshots or screencast