Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-publish panel wording to accurately describe the review process #67328

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

sarthaknagoshe2002
Copy link
Contributor

@sarthaknagoshe2002 sarthaknagoshe2002 commented Nov 26, 2024

fixes: #65368

What?

This PR updates the pre-publish panel description shown to contributors when submitting a post for review. The updated text removes assumptions about the role of the reviewer and eliminates unnecessary wording for better clarity.

Why?

The previous wording inaccurately implied that only users with the Editor role could review and publish the post. In reality, any user with the publish capability can do so. Additionally, "When you’re ready" was redundant since users are already prompted to click "Submit for Review."

How?

Replaced "an Editor will be able to approve it for you" with "a user with publishing permissions can review it for you."
Removed "When you’re ready" to streamline the message.

Testing Instructions

  1. Log in as a Contributor
  2. Create a new post.
  3. Click "Submit for Review."
  4. Verify Updated Message
  5. Check the pre-publish panel description for clarity and accuracy.
  6. Ensure the text no longer references "Editor" or includes redundant phrasing.

Screenshots or screencast

Before After
Screenshot 2024-12-04 at 6 50 05 PM Screenshot 2024-12-04 at 6 50 27 PM

Copy link

github-actions bot commented Nov 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sarthaknagoshe2002 <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: hanneslsm <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sarthaknagoshe2002
Copy link
Contributor Author

As per the suggestion give by @hanneslsm, here are the visuals of the changes.

Screenshot 2024-11-27 at 4 53 01 PM

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor labels Dec 6, 2024
@afercia
Copy link
Contributor

afercia commented Dec 6, 2024

Looks good to me, thanks!
Pending design feedback. Cc @WordPress/gutenberg-design

@jasmussen
Copy link
Contributor

Seems good, thanks for the PR.

Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afercia afercia merged commit 00c32f4 into WordPress:trunk Dec 6, 2024
68 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 6, 2024
@sarthaknagoshe2002 sarthaknagoshe2002 deleted the fix/issue-65368 branch December 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review the wording of the pre-publish panel description when submitting for review as a contributor
3 participants