Zoom Out: Use the zoom-level value to scale the iframe #66280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
tellthemachines and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +37 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Oct 22, 2024
| @@ -354,7 +354,7 @@ function Iframe( { | |||
| // but calc( 100px / 2px ) is not. | |||
| iframeDocument.documentElement.style.setProperty( | |||
| '--wp-block-editor-iframe-zoom-out-scale', | |||
| scale === 'default' | |||
| scale === 'auto-scaled' | |||
There was a problem hiding this comment.
Is this just a case of not wanting to set a scale as a percentage, but instead a certain width?
There was a problem hiding this comment.
Because it seems this "auto scaling" is just a hardcoded 750px width.
There was a problem hiding this comment.
Yeah, I'm not entirely how the computation works, it's computed using the actual width of the window and a maxWidth of 750 for the zoom-out area.
I would be fine removing it and setting a percentage but I don't have too much context here.
There was a problem hiding this comment.
My point is: does it make sense to have a % API? Are we using that as third party somewhere? Would a width work there instead?
There was a problem hiding this comment.
Ah good point, Well, in my mind, the zoom level becomes kind of like a range picker (see the storybook), in which case the % API seems better no?
There was a problem hiding this comment.
I always saw the state as representing a percentage of zoom 👍
There was a problem hiding this comment.
Any way we can make this auto scaled private? Maybe a symbol?
draganescu
reviewed
Oct 22, 2024
|
@draganescu Good catch, it's fixed now. |
youknowriad
force-pushed
the
update/use-zoom-level-value
branch
from
bb92c9a to
f0c2542
Compare
ellatrix
approved these changes
Oct 23, 2024
|
For now, all of that is still a private API. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: getdave <[email protected]>
This is an |
setZoomLevel, resetZoomLevel are private APIs, what APIs are you talking about here? |
The |
Right, I missed that part. The Iframe component was introduced before we introduce private APIs, so it's not entirely stable, it's one of these APIs where we need to be careful of the changes we do, check usage... but we should still consider changes if there's no impact. The reason is these prefixed APIs were introduced without thoughtfully thought for public access, they were never meant to be stable. That said, I'm curious here, did you face an issue somewhere? I'm happy to take a look. |
Just had an old branch before the change that I rebased and wasn't working because of this. It was just a matter of changing the string, but I figured I should mention it because of possible 3rd party consumers of the component. And I wanted to make sure I wasn't imaging things about I don't expect many 3rd party consumers are using it, but maybe it's worth a dev note or something since it is technically a breaking change. |
youknowriad
added
the
Needs Dev Note
|
Good call, I added the dev note flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #50739
What?
We have a "zoom-level" state in the block editor but it's not really used, we just force an automatic scale in the frame.
This PR updates the block editor package to actually use the value.
I kept the automatic scaling in place so the zoom level value can be either "auto-scaled" or a number between 0 and 100.
Why?
This is a preparation to open a public API for the zoom level.
Testing Instructions
npm run storybook:devto check it.