Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position BlockToolbar below all of the selected block's descendants #62711

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Position BlockToolbar below all of the selected block's descendants #62711

merged 10 commits into from
Aug 26, 2024

Commits on Aug 25, 2024

  1. Position BlockToolbar below all of the selected block's descendants

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    7b8728c View commit details
    Browse the repository at this point in the history

  2. Fix scrolling

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    1c0cc4e View commit details
    Browse the repository at this point in the history

  3. Don't use window global

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f014ef2 View commit details
    Browse the repository at this point in the history

  4. Explain what capturingClientId is

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    70fe5b1 View commit details
    Browse the repository at this point in the history

  5. No need to clip bounds to viewport

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    594d549 View commit details
    Browse the repository at this point in the history

  6. Use explicit check for VisuallyHidden

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    3ecc1c9 View commit details
    Browse the repository at this point in the history

  7. To calculate visible bounds using rectUnion, take into account the ou… 

    …ter limits of the container in which an element is supposed to be "visible"

For example, if an element is positioned -10px to the left of the window x value (0), we should discount the negative overhang because it's not visible and therefore to be counted in the visible calculations.

Updated comments
    @ramonjd
    ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    d2d2841 View commit details
    Browse the repository at this point in the history

  8. grammar in the comment

    @ramonjd
    ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    06b1866 View commit details
    Browse the repository at this point in the history

  9. Remove caching optimization. Better for a follow up if there are conc… 

    …erns.
    @ramonjd
    ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f0d4601 View commit details
    Browse the repository at this point in the history

  10. switch to checkVisibility DOM method

    @ramonjd
    ramonjd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    675b3a6 View commit details
    Browse the repository at this point in the history