Remove open in new tab from link preview #58744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
added
the
[Feature] Link Editing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -59 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
tweak/linkcontrol-preview
branch
from
4aa7bef to
cf112d7
Compare
scruffian
force-pushed
the
tweak/linkcontrol-preview
branch
from
cf112d7 to
e91e505
Compare
jeryj
force-pushed
the
update/remove-open-in-new-tab
branch
from
61d3d03 to
4106d25
Compare
jeryj
force-pushed
the
update/remove-open-in-new-tab
branch
from
4106d25 to
8d3385d
Compare
|
I restarted the React Native tests. If they fail again then let's reach out in #mobile on WP Slack to see if the failure is legit. If it's a false flag then we can force merge this one. |
|
Good stuff, thanks! |
|
👋 Hi @scruffian! Just a friendly reminder to manually review, update as needed, and include the If it was on accident, no big deal! But just trying to make sure everyone is aware as we retrain our brains. 😄 |
|
Oh yeah sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes open in new tab from link control preview as a follow-up to #58183
Why?
Adding the "Opens in new tab" checkbox to the preview was a temporary stop gap solution to allow content creators to more easily updated created links. This was because we previously remove the "Settings" controls from the initial link creation step and this caused some unexpected UX issues for certain users.
Recent advancements in the UX of the Link UI however, mean that the UI remains open after the initial link creation. This means users now need only click "Edit" to access the
Opens in new tab.This workflow should be sufficient to avoid overburdening users who regularly create links that must open in a new tab.
In the future iterations on the Link UI, we may even default to the "Edit" view upon initial link creation which would further streamline this flow.
For now however, it makes sense to remove the "hotfix" which gave special precedence to the
Opens in new tab. This unifies the control and standardises the interface.How?
Removes
addionalControlsfrom<LinkPreview />component.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast